[MLIR] Add support for Tuples with integer keys #1260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rsetaluri
force-pushed
the
mlir-add-tuple-support
branch
from
e1a0494
to
a4fb642
Compare
rsetaluri
force-pushed
the
mlir-add-tuple-support
branch
from
a4fb642
to
f15e28d
Compare
rsetaluri
changed the title
rsetaluri
changed the title
leonardt
approved these changes
Apr 10, 2023
There was a problem hiding this comment.
Looks good, but I wonder if we could somehow encapsulate the retrieval of a safe index string into the type? E.g. add an API to tuple/product to get a "safe_index" for each field (where tuple would prepend the underscore). This would avoid having to deal with the Product vs Tuple check in the backend and allows for future extensibility (e.g. a user could subclass Tuple and define custom behavior, but they may need the ability to provide a "safe_index").
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #1252.
Fixes this issue by prefixing tuple field keys with "_". This must be in sync between:
Note that struct creation does not need to be aware of this.
We use a common
tuple_key_to_str()function (still specific to MLIR) to achieve this.